Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow upgrade major version on RDS Aurora when use custom parameter groups #18820

Closed
wants to merge 1 commit into from
Closed

Allow upgrade major version on RDS Aurora when use custom parameter groups #18820

wants to merge 1 commit into from

Conversation

gdepuille
Copy link
Contributor

@gdepuille gdepuille commented Apr 13, 2021 •
edited by YakDriver
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17357
Superceded by #17111

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRDSCluster'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSCluster -timeout 180m
=== RUN   TestAccAWSRDSClusterEndpoint_basic
=== PAUSE TestAccAWSRDSClusterEndpoint_basic
=== RUN   TestAccAWSRDSClusterEndpoint_tags
=== PAUSE TestAccAWSRDSClusterEndpoint_tags
=== RUN   TestAccAWSRDSClusterInstance_basic
=== PAUSE TestAccAWSRDSClusterInstance_basic
=== RUN   TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted
=== PAUSE TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted
=== RUN   TestAccAWSRDSClusterInstance_az
=== PAUSE TestAccAWSRDSClusterInstance_az
=== RUN   TestAccAWSRDSClusterInstance_namePrefix
=== PAUSE TestAccAWSRDSClusterInstance_namePrefix
=== RUN   TestAccAWSRDSClusterInstance_generatedName
=== PAUSE TestAccAWSRDSClusterInstance_generatedName
=== RUN   TestAccAWSRDSClusterInstance_kmsKey
=== PAUSE TestAccAWSRDSClusterInstance_kmsKey
=== RUN   TestAccAWSRDSClusterInstance_disappears
=== PAUSE TestAccAWSRDSClusterInstance_disappears
=== RUN   TestAccAWSRDSClusterInstance_PubliclyAccessible
=== PAUSE TestAccAWSRDSClusterInstance_PubliclyAccessible
=== RUN   TestAccAWSRDSClusterInstance_CopyTagsToSnapshot
=== PAUSE TestAccAWSRDSClusterInstance_CopyTagsToSnapshot
=== RUN   TestAccAWSRDSClusterInstance_MonitoringInterval
=== PAUSE TestAccAWSRDSClusterInstance_MonitoringInterval
=== RUN   TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled
=== PAUSE TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled
=== RUN   TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved
=== PAUSE TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved
=== RUN   TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled
=== PAUSE TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql
=== RUN   TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey
=== PAUSE TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey
=== RUN   TestAccAWSRDSClusterInstance_CACertificateIdentifier
=== PAUSE TestAccAWSRDSClusterInstance_CACertificateIdentifier
=== RUN   TestAccAWSRDSCluster_basic
=== PAUSE TestAccAWSRDSCluster_basic
=== RUN   TestAccAWSRDSCluster_AllowMajorVersionUpgrade
=== PAUSE TestAccAWSRDSCluster_AllowMajorVersionUpgrade
=== RUN   TestAccAWSRDSCluster_AllowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccAWSRDSCluster_AllowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccAWSRDSCluster_AvailabilityZones
=== PAUSE TestAccAWSRDSCluster_AvailabilityZones
=== RUN   TestAccAWSRDSCluster_BacktrackWindow
=== PAUSE TestAccAWSRDSCluster_BacktrackWindow
=== RUN   TestAccAWSRDSCluster_ClusterIdentifierPrefix
=== PAUSE TestAccAWSRDSCluster_ClusterIdentifierPrefix
=== RUN   TestAccAWSRDSCluster_DbSubnetGroupName
=== PAUSE TestAccAWSRDSCluster_DbSubnetGroupName
=== RUN   TestAccAWSRDSCluster_s3Restore
=== PAUSE TestAccAWSRDSCluster_s3Restore
=== RUN   TestAccAWSRDSCluster_PointInTimeRestore
=== PAUSE TestAccAWSRDSCluster_PointInTimeRestore
=== RUN   TestAccAWSRDSCluster_PointInTimeRestore_EnabledCloudwatchLogsExports
=== PAUSE TestAccAWSRDSCluster_PointInTimeRestore_EnabledCloudwatchLogsExports
=== RUN   TestAccAWSRDSCluster_generatedName
=== PAUSE TestAccAWSRDSCluster_generatedName
=== RUN   TestAccAWSRDSCluster_takeFinalSnapshot
=== PAUSE TestAccAWSRDSCluster_takeFinalSnapshot
=== RUN   TestAccAWSRDSCluster_missingUserNameCausesError
=== PAUSE TestAccAWSRDSCluster_missingUserNameCausesError
=== RUN   TestAccAWSRDSCluster_Tags
=== PAUSE TestAccAWSRDSCluster_Tags
=== RUN   TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL
=== PAUSE TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL
=== RUN   TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql
=== PAUSE TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql
=== RUN   TestAccAWSRDSCluster_updateIamRoles
=== PAUSE TestAccAWSRDSCluster_updateIamRoles
=== RUN   TestAccAWSRDSCluster_kmsKey
=== PAUSE TestAccAWSRDSCluster_kmsKey
=== RUN   TestAccAWSRDSCluster_encrypted
=== PAUSE TestAccAWSRDSCluster_encrypted
=== RUN   TestAccAWSRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccAWSRDSCluster_copyTagsToSnapshot
=== RUN   TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
=== PAUSE TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
=== RUN   TestAccAWSRDSCluster_backupsUpdate
=== PAUSE TestAccAWSRDSCluster_backupsUpdate
=== RUN   TestAccAWSRDSCluster_iamAuth
=== PAUSE TestAccAWSRDSCluster_iamAuth
=== RUN   TestAccAWSRDSCluster_DeletionProtection
=== PAUSE TestAccAWSRDSCluster_DeletionProtection
=== RUN   TestAccAWSRDSCluster_EngineMode
=== PAUSE TestAccAWSRDSCluster_EngineMode
=== RUN   TestAccAWSRDSCluster_EngineMode_Global
=== PAUSE TestAccAWSRDSCluster_EngineMode_Global
=== RUN   TestAccAWSRDSCluster_EngineMode_Multimaster
=== PAUSE TestAccAWSRDSCluster_EngineMode_Multimaster
=== RUN   TestAccAWSRDSCluster_EngineMode_ParallelQuery
=== PAUSE TestAccAWSRDSCluster_EngineMode_ParallelQuery
=== RUN   TestAccAWSRDSCluster_EngineVersion
=== PAUSE TestAccAWSRDSCluster_EngineVersion
=== RUN   TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance
=== PAUSE TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Add
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Add
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Remove
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Remove
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Update
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Update
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier
=== PAUSE TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier
=== RUN   TestAccAWSRDSCluster_Port
=== PAUSE TestAccAWSRDSCluster_Port
=== RUN   TestAccAWSRDSCluster_ScalingConfiguration
=== PAUSE TestAccAWSRDSCluster_ScalingConfiguration
=== RUN   TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity
=== PAUSE TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless
    resource_aws_rds_cluster_test.go:1865: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s)
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_KmsKeyId
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_KmsKeyId
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_Tags
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_Tags
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags
=== RUN   TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore
=== PAUSE TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore
=== RUN   TestAccAWSRDSCluster_EnableHttpEndpoint
=== PAUSE TestAccAWSRDSCluster_EnableHttpEndpoint
=== CONT  TestAccAWSRDSClusterEndpoint_basic
=== CONT  TestAccAWSRDSCluster_updateIamRoles
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier
=== CONT  TestAccAWSRDSCluster_Port
=== CONT  TestAccAWSRDSCluster_EnableHttpEndpoint
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_Tags
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_KmsKeyId
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection
=== CONT  TestAccAWSRDSCluster_SnapshotIdentifier
--- PASS: TestAccAWSRDSCluster_Port (260.76s)
=== CONT  TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity
--- PASS: TestAccAWSRDSCluster_updateIamRoles (319.75s)
=== CONT  TestAccAWSRDSCluster_ScalingConfiguration
--- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (446.46s)
=== CONT  TestAccAWSRDSCluster_EngineMode_Multimaster
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (460.43s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (462.37s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (476.38s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Update
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (498.64s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Remove
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (501.64s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Add
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (504.34s)
=== CONT  TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (504.81s)
=== CONT  TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (519.33s)
=== CONT  TestAccAWSRDSCluster_EngineVersion
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (520.61s)
=== CONT  TestAccAWSRDSCluster_EngineMode_ParallelQuery
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (524.61s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (526.93s)
=== CONT  TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_KmsKeyId (529.81s)
=== CONT  TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (548.01s)
=== CONT  TestAccAWSRDSCluster_Tags
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration_DefaultMinCapacity (300.61s)
=== CONT  TestAccAWSRDSCluster_missingUserNameCausesError
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (566.68s)
=== CONT  TestAccAWSRDSCluster_takeFinalSnapshot
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (8.62s)
=== CONT  TestAccAWSRDSCluster_generatedName
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (586.66s)
=== CONT  TestAccAWSRDSCluster_PointInTimeRestore_EnabledCloudwatchLogsExports
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Provisioned (168.51s)
=== CONT  TestAccAWSRDSCluster_PointInTimeRestore
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (184.71s)
=== CONT  TestAccAWSRDSCluster_s3Restore
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (165.61s)
=== CONT  TestAccAWSRDSCluster_DbSubnetGroupName
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql (168.88s)
=== CONT  TestAccAWSRDSCluster_ClusterIdentifierPrefix
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Update (222.20s)
=== CONT  TestAccAWSRDSCluster_BacktrackWindow
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (385.09s)
=== CONT  TestAccAWSRDSCluster_AvailabilityZones
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Add (208.07s)
=== CONT  TestAccAWSRDSCluster_AllowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global_Remove (211.92s)
=== CONT  TestAccAWSRDSCluster_AllowMajorVersionUpgrade
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_EngineMode_Global (213.61s)
=== CONT  TestAccAWSRDSCluster_basic
--- PASS: TestAccAWSRDSCluster_generatedName (178.94s)
=== CONT  TestAccAWSRDSClusterInstance_CACertificateIdentifier
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (212.37s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL (266.39s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql
--- PASS: TestAccAWSRDSCluster_Tags (248.79s)
=== CONT  TestAccAWSRDSCluster_backupsUpdate
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (160.86s)
=== CONT  TestAccAWSRDSCluster_EngineMode_Global
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (179.70s)
=== CONT  TestAccAWSRDSCluster_EngineMode
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (198.93s)
=== CONT  TestAccAWSRDSCluster_DeletionProtection
--- PASS: TestAccAWSRDSCluster_basic (169.17s)
=== CONT  TestAccAWSRDSCluster_iamAuth
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (200.94s)
=== CONT  TestAccAWSRDSCluster_copyTagsToSnapshot
--- PASS: TestAccAWSRDSCluster_PointInTimeRestore_EnabledCloudwatchLogsExports (392.63s)
=== CONT  TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
--- PASS: TestAccAWSRDSCluster_backupsUpdate (201.00s)
=== CONT  TestAccAWSRDSClusterInstance_MonitoringInterval
--- PASS: TestAccAWSRDSCluster_EngineVersion (498.65s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2
--- PASS: TestAccAWSRDSCluster_iamAuth (157.20s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey
--- PASS: TestAccAWSRDSCluster_PointInTimeRestore (416.12s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (201.12s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql
--- PASS: TestAccAWSRDSCluster_DeletionProtection (200.04s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (265.31s)
=== CONT  TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1276.40s)
=== CONT  TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (833.60s)
=== CONT  TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved
--- PASS: TestAccAWSRDSCluster_EngineMode (485.95s)
=== CONT  TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (651.30s)
=== CONT  TestAccAWSRDSClusterInstance_generatedName
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (687.29s)
=== CONT  TestAccAWSRDSClusterInstance_CopyTagsToSnapshot
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (676.65s)
=== CONT  TestAccAWSRDSClusterInstance_PubliclyAccessible
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1079.66s)
=== CONT  TestAccAWSRDSClusterInstance_disappears
=== CONT  TestAccAWSRDSCluster_s3Restore
    resource_aws_rds_cluster_test.go:409: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error waiting for RDS Cluster state to be "available": unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>)
        
          on terraform_plugin_test.tf line 74, in resource "aws_rds_cluster" "test":
          74: resource "aws_rds_cluster" "test" {
        
        
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (686.74s)
=== CONT  TestAccAWSRDSClusterInstance_kmsKey
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (695.26s)
=== CONT  TestAccAWSRDSCluster_encrypted
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (697.29s)
=== CONT  TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (740.86s)
=== CONT  TestAccAWSRDSClusterInstance_namePrefix
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (805.26s)
=== CONT  TestAccAWSRDSClusterInstance_az
--- PASS: TestAccAWSRDSCluster_encrypted (147.67s)
=== CONT  TestAccAWSRDSCluster_kmsKey
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_ReplicationSourceIdentifier (1891.82s)
=== CONT  TestAccAWSRDSClusterInstance_basic
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (870.39s)
=== CONT  TestAccAWSRDSClusterEndpoint_tags
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (786.11s)
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgrade (1385.20s)
--- PASS: TestAccAWSRDSCluster_kmsKey (210.64s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (727.39s)
--- FAIL: TestAccAWSRDSCluster_s3Restore (1564.22s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (770.46s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (844.04s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (697.95s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (834.58s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (607.17s)
--- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (689.55s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1979.76s)
=== CONT  TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
    testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Database Instance "tf-acc-test-8643813325380297167-primary": InvalidDBClusterStateFault: Cannot delete the last instance of the master cluster while a replication is being setup. Wait until the replication setup completes and try again.
                status code: 400, request id: 001494ec-26df-4e1a-ac06-2553f5d27586
        
        
--- FAIL: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1461.66s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1096.79s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1526.71s)
--- PASS: TestAccAWSRDSCluster_AllowMajorVersionUpgradeWithCustomParameters (1817.23s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1172.08s)
--- PASS: TestAccAWSRDSClusterInstance_az (801.34s)
--- PASS: TestAccAWSRDSClusterEndpoint_tags (1102.80s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1634.84s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       3526.875s
FAIL

After the first run of acceptance tests. I've run independtly the two failed tests.

The results is below :

  • TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId:
$ make testacc TESTARGS='-run=TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId -timeout 180m
=== RUN   TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
=== PAUSE TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
=== CONT  TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId
--- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1623.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1623.529s
  • TestAccAWSRDSCluster_s3Restore :
$ make testacc TESTARGS='-run=TestAccAWSRDSCluster_s3Restore'

However I think the problem is the test itself. The AWS console show this logs when the test run :

image

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 13, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2021
@gdepuille gdepuille changed the title [WIP] Allow upgrade major version on RDS Aurora when use custom parameter groups Allow upgrade major version on RDS Aurora when use custom parameter groups Apr 13, 2021
@gdepuille gdepuille marked this pull request as ready for review April 13, 2021 16:29
@gdepuille gdepuille requested a review from a team as a code owner April 13, 2021 16:29
@YakDriver
Copy link
Member

TestAccAWSRDSCluster_s3Restore has been failing for some time. Hopefully we will be able to fix one day. See #13391

@YakDriver
Copy link
Member

@gdepuille Thanks for this PR! After a quick glance, it looks to be complete. Make sure you allow edits by maintainers in case there are changes needed to get this merged. Hopefully we will have a chance to review soon.

@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2021
@gogrisohil
Copy link

Is there a timeline for merging this? We're experiencing this issue and we're hoping to have this PR merged and released.

@toneill818
Copy link

@YakDriver Any chance this PR gets merged? We are experiencing this issue too and hoping to get this PR merged and released.

@yongzhang
Copy link

We're also waiting this feature to be released.

@svenedge svenedge mentioned this pull request Sep 7, 2021
Merged
@YakDriver YakDriver self-assigned this Oct 13, 2021
@YakDriver
Copy link
Member

Thank you for your work on this! Your commits were included with #17111. Of course, you still receive credit for them.

@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.63.0
Development

Successfully merging this pull request may close these issues.

Add support for DBInstanceParameterGroupName in aws_rds_cluster
5 participants
@gdepuille @YakDriver @gogrisohil @toneill818 @yongzhang